Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing name detection to odo analyze #6649

Closed
kadel opened this issue Mar 8, 2023 · 1 comment · Fixed by #6682
Closed

missing name detection to odo analyze #6649

kadel opened this issue Mar 8, 2023 · 1 comment · Fixed by #6682
Assignees
@valaparthvi
Labels
good first issue Denotes an issue ready for a new contributor. Maintainers will help mentor new contributors. kind/bug Categorizes issue or PR as related to a bug.
Milestone
v3.9.0 🚀

Comments

@kadel
Copy link
Member

kadel commented Mar 8, 2023

odo analyze -o json output is missing name field.

odo init uses alyzer to suggest default name, this shoudl be in odo analyze output together with other alyzer detections.

/kind bug
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 8, 2023
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Mar 8, 2023
@rm3l rm3l added this to odo Project Mar 8, 2023
@kadel kadel mentioned this issue Mar 8, 2023
Closed
@rm3l rm3l added good first issue Denotes an issue ready for a new contributor. Maintainers will help mentor new contributors. and removed needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. labels Mar 22, 2023
@rm3l
Copy link
Member

rm3l commented Mar 22, 2023 •
edited
Loading

Grooming (2023-03-22)

Make sure we check that there is no other information detected and missing in the output.

@rm3l rm3l added this to the v3.9.0 🚀 milestone Mar 23, 2023
@valaparthvi valaparthvi moved this to In Review 👀 in odo Project Mar 27, 2023
@rm3l rm3l mentioned this issue Mar 27, 2023
Merged
3 tasks
@github-project-automation github-project-automation bot moved this from In Review 👀 to Done ✅ in odo Project Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valaparthvi valaparthvi

Labels
good first issue Denotes an issue ready for a new contributor. Maintainers will help mentor new contributors. kind/bug Categorizes issue or PR as related to a bug.
Projects
odo Project
Archived in project
Milestone
v3.9.0 🚀
Development

Successfully merging a pull request may close this issue.

Add name detection to odo analyze valaparthvi/odo
3 participants
@kadel @rm3l @valaparthvi