Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Serverless Functions into OpenShift Toolkit extension #2993

Closed
3 tasks done
mohitsuman opened this issue Jun 28, 2023 · 5 comments · Fixed by #3003
Closed
3 tasks done

Implement Serverless Functions into OpenShift Toolkit extension #2993

mohitsuman opened this issue Jun 28, 2023 · 5 comments · Fixed by #3003
Assignees
Labels
kind/enhancement New feature or request
Milestone

Comments

@mohitsuman
Copy link
Collaborator

mohitsuman commented Jun 28, 2023

Implement the OpenShift Serverless view into OpenShift Toolkit extension.

  • Add a new view in the navigation with name as Serverless Functions
  • Rewrite the UI in material UI workflow in sync with vscode theme. Remove the old UI elements completely
  • Update to latest func cli https://github.com/knative/func
@rgrunber
Copy link
Member

@datho7561 do you see anything in https://github.com/redhat-developer/vscode-knative/ not playing well with esbuild ? Otherwise , size shouldn't be an issue.

@datho7561
Copy link
Contributor

Yes, shelljs doesn't play well with esbuild. We can probably use alternatives to shelljs, but that will require a bit more effort.

@datho7561
Copy link
Contributor

Does knative have any webviews?

@msivasubramaniaan
Copy link
Collaborator

msivasubramaniaan commented Jun 28, 2023

Yes it has.

We are going to add only function CLI on OpenShift extension. I hope the size shouldn't be a problem.

@mohitsuman
Copy link
Collaborator Author

Does knative have any webviews?

It has webviews, but onty few and the idea is to add more webviews in the future. For dependencies that do not work well, we can update them. Given the repo has not been touched in a while, I would like that when we implement it, we add dependencies as per our toolkit workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment