From 0db1c77a9cf0796181ede63d6507222e5d97376c Mon Sep 17 00:00:00 2001 From: Victor Rubezhny Date: Wed, 30 Aug 2023 03:02:59 +0200 Subject: [PATCH] [build] Use Node.js v18.17.1 (LTS) Fixes: #3121 Signed-off-by: Victor Rubezhny --- .github/workflows/continuous-integration-workflow.yml | 2 +- .github/workflows/release.yml | 4 ++-- .nvmrc | 2 +- CONTRIBUTING.md | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/continuous-integration-workflow.yml b/.github/workflows/continuous-integration-workflow.yml index be5288bf9..1b866cb5b 100644 --- a/.github/workflows/continuous-integration-workflow.yml +++ b/.github/workflows/continuous-integration-workflow.yml @@ -19,7 +19,7 @@ jobs: strategy: matrix: os: [macos-latest, windows-latest, ubuntu-latest] - node: [ '16' ] + node: [ '18' ] # Steps represent a sequence of tasks that will be executed as part of the job steps: diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index aa752ee4b..921b5ba78 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -37,7 +37,7 @@ jobs: - name: Use Node.js uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - name: Install dependencies run: | npm install -g typescript "vsce" "ovsx" @@ -92,7 +92,7 @@ jobs: - name: Use Node.js uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - name: Install dependencies run: | npm install -g typescript "vsce" "ovsx" diff --git a/.nvmrc b/.nvmrc index e0325e5ad..860cc5000 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -v16.17.1 +v18.17.1 diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 76b50935a..1bc020839 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -8,7 +8,7 @@ There are only a few guidelines that we need contributors to follow. ## First Time Setup 1. Install prerequisites: * latest [Visual Studio Code](https://code.visualstudio.com/) - * [Node.js](https://nodejs.org/) v16.17.0 or higher + * [Node.js](https://nodejs.org/) v18.17.0 or higher * It is recommended to set up `nvm` to manage different versions of node, which can be installed by following the instructions [here](https://github.com/nvm-sh/nvm#installing-and-updating). * To use the current recommended version for this project (in`./nvmrc`), run `nvm use`. * [Red Hat Authentication](https://marketplace.visualstudio.com/items?itemName=redhat.vscode-redhat-account) VS Code plugin (VS Code will prompt to install this when you launch the extension if you don't have it)