GitHub is mis-cased in the edit image #1421
Comments
|
This image has been removed so this issue is closed. @amoralej can you close this one? |
|
I'm not sure what you mean. The image is still very much in https://github.com/redhat-openstack/website/blob/master/source/images/edit.png and https://github.com/redhat-openstack/website/tree/master/source/images If you either fix the content of the image or delete the image from the tip of Until then, the file itself is an attractive nuisance -- someone may choose to use it thinking it's good, when it's in fact bad. If you're no longer using the file, then deleting it should be a pretty simple task. |
|
Josh we removed the image from the site as part of another issue.
… On Mar 19, 2021, at 3:10 PM, Josh Soref ***@***.***> wrote:
I'm not sure what you mean. The image is still very much in https://github.com/redhat-openstack/website/blob/master/source/images/edit.png and https://github.com/redhat-openstack/website/tree/master/source/images
If you either fix the content of the image or delete the image from the tip of master, then it's removed.
Until then, the file itself is an attractive nuisance -- someone may choose to use it thinking it's good, when it's in fact bad.
If you're no longer using the file, then deleting it should be a pretty simple task.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Great, so you can delete the file from the repository, would it help if I created the PR for it? |
|
Josh we switched to using Gerrit for patches and reviews. You're more than
welcome to put up a patch at https://review.rdoproject.org/r/ or I can do
it for you.
…On Fri, Mar 19, 2021 at 3:35 PM Josh Soref ***@***.***> wrote:
Great, so you can delete the file from the repository, would it help if I
created the PR for it?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1421 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB5YEIGKFYY5QPUGJSKE2X3TEOYQXANCNFSM4VDF3BHA>
.
|
|
Please do it for me, thanks. |
rdoproject
pushed a commit
that referenced
this issue
Mar 31, 2021
As requested in GitHub is mis-cased in the edit image (#1421) the edit.png file has been removed the repo. It was no longer in use due to switch to Gerrit Change-Id: I2e4369bd2ad127fa7559e62466a8ba9edbb73fac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See GitHub
The text was updated successfully, but these errors were encountered: