Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for other formats than SARIF #397

Open
mpoberezhniy opened this issue May 1, 2024 · 2 comments · Fixed by #400 or #404
Open

Add support for other formats than SARIF #397

mpoberezhniy opened this issue May 1, 2024 · 2 comments · Fixed by #400 or #404
Labels

Comments

@mpoberezhniy
Copy link
Contributor

mpoberezhniy commented May 1, 2024

Type of issue

Feature Request

Description

Add support for converting SARIF reports to other formats. Or provide examples on how to use with other CI/CD tools and git hosting systems.

Describe the solution you'd like

Convert SARIF to other formats using sarif-tools
Supported formats:

  • codeclimate - can be used in GitLab and GitHub, but generally is an open-source tool that could be used elsewhere
  • csv
  • txt
  • html - can be used with other CI/CD tools outside VCS hosting platforms
  • docx

Codeclimate json format is accepted by GitLab and adds Merge request notes similar to GitHub Pull request comments: notes example.

Consider supporting Gerrit API json format: review API reference. This can be composed from SARIF, but parsing it from codeclimate json format should be easier.

@jamacku
Copy link
Member

jamacku commented May 2, 2024

Differential ShellCheck internally uses csdiff and csgrep, tools written by @kdudka and @lzaoral.

csdiff handles the differential part of scanning, and csgrep is used to produce various formats (e.g., JSON, SARIF, HTML, txt). Differential ShellCheck itself doesn't handle conversion, and I would like to avoid adding a dependency on sarif-tools.

We are already providing sarif output. You can use this output as input for sarif-tools.

I'm not entirely against adding sarif-tools integration, but they must first be packaged into Fedora.

@mpoberezhniy
Copy link
Contributor Author

I agree. I think we should just provide an example of using sarif-tools to integrate differential-shellcheck executable with other platforms.

I am trying to add Gerrit Review API support to sarif-tools and will provide some examples in this issue.

@jamacku jamacku linked a pull request May 3, 2024 that will close this issue
@mergify mergify bot closed this as completed in #400 May 3, 2024
@jamacku jamacku reopened this May 3, 2024
@jamacku jamacku linked a pull request May 6, 2024 that will close this issue
@jamacku jamacku reopened this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants