Do not provide nil values for missing connection pool options #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tubbo
requested changes
Nov 14, 2018
There was a problem hiding this comment.
@shepmaster thank you so much for the PR and issue report! sorry it took me a little bit to respond. this definitely had to do with some refactoring I did on Redis::Rack that definitely passed tests. take a look at the comment I made...in addition I feel like we need an additional unit test that ensures if :pool_size or :pool_timeout are nil, then neither :size nor :timeout appear as keys in #pool_options.
shepmaster
force-pushed
the
pool-options
branch
from
00f9fc5
to
b739ee6
Compare
|
Updated. |
tubbo
requested changes
Dec 18, 2018
shepmaster
force-pushed
the
pool-options
branch
from
b739ee6
to
ef999d6
Compare
tubbo
approved these changes
Dec 19, 2018
tubbo
requested changes
Dec 19, 2018
shepmaster
force-pushed
the
pool-options
branch
from
ef999d6
to
8edcb1d
Compare
tubbo
approved these changes
Dec 19, 2018
|
thanks @shepmaster! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44