From 515043aaab9e06b0216f79472b628e76802a5161 Mon Sep 17 00:00:00 2001 From: Vladimir Mihailenco Date: Mon, 30 Jan 2023 10:10:49 +0200 Subject: [PATCH] chore: fix test --- extra/rediscmd/rediscmd_test.go | 1 - extra/redisotel/redisotel_test.go | 26 -------------------------- 2 files changed, 27 deletions(-) diff --git a/extra/rediscmd/rediscmd_test.go b/extra/rediscmd/rediscmd_test.go index 6c60cdabb..2219ab0f2 100644 --- a/extra/rediscmd/rediscmd_test.go +++ b/extra/rediscmd/rediscmd_test.go @@ -4,7 +4,6 @@ import ( "testing" . "github.com/bsm/ginkgo/v2" - . "github.com/bsm/ginkgo/v2/extensions/table" . "github.com/bsm/gomega" ) diff --git a/extra/redisotel/redisotel_test.go b/extra/redisotel/redisotel_test.go index 440288019..fd75361e8 100644 --- a/extra/redisotel/redisotel_test.go +++ b/extra/redisotel/redisotel_test.go @@ -34,32 +34,6 @@ func TestNewWithTracerProvider(t *testing.T) { } } -func TestNewWithAttributes(t *testing.T) { - provider := sdktrace.NewTracerProvider() - hook := newTracingHook("", WithTracerProvider(provider), WithAttributes(semconv.NetPeerNameKey.String("localhost"))) - ctx, span := provider.Tracer("redis-test").Start(context.TODO(), "redis-test") - cmd := redis.NewCmd(ctx, "ping") - defer span.End() - - processHook := hook.ProcessHook(func(ctx context.Context, cmd redis.Cmder) error { - attrs := trace.SpanFromContext(ctx).(sdktrace.ReadOnlySpan).Attributes() - if !(attrs[0] == semconv.DBSystemRedis) { - t.Fatalf("expected attrs[0] to be semconv.DBSystemRedis, got: %v", attrs[0]) - } - if !(attrs[1] == semconv.NetPeerNameKey.String("localhost")) { - t.Fatalf("expected attrs[1] to be semconv.NetPeerNameKey.String(\"localhost\"), got: %v", attrs[1]) - } - if !(attrs[2] == semconv.DBStatementKey.String("ping")) { - t.Fatalf("expected attrs[2] to be semconv.DBStatementKey.String(\"ping\"), got: %v", attrs[2]) - } - return nil - }) - err := processHook(ctx, cmd) - if err != nil { - t.Fatal(err) - } -} - func TestWithDBStatement(t *testing.T) { provider := sdktrace.NewTracerProvider() hook := newTracingHook(