feat: add client info command #2483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: monkey92t <golang@88.com>
chayim
reviewed
Mar 13, 2023
vmihailenco
reviewed
Apr 12, 2023
vmihailenco
reviewed
Apr 12, 2023
|
I would merge this as is since I would also consider not adding this API at all since it will break a lot and will require some efforts to maintain. @chayim what do you think? |
vmihailenco
previously approved these changes
Apr 19, 2023
Signed-off-by: monkey92t <golang@88.com>
Signed-off-by: monkey92t <golang@88.com>
Merged
chayim
approved these changes
Apr 24, 2023
|
Nobody is objecting to it at the moment, so we will merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can also consider improving
client listin the future.fix #2482