Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for internal/hscan/structmap.go:89:23: undefined: reflect.Pointer #2458

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

eepurichandra
Copy link
Contributor

No description provided.

Copy link
Collaborator

@monkey92t monkey92t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, we accept this PR, but it is recommended to upgrade go1.18 above versions.

@monkey92t monkey92t merged commit 6ec4585 into redis:master Feb 24, 2023
@Shirtiny
Copy link

I really want to upgrade to Go 1.18, but some cloud platforms only support Go 1.7, and it makes me cry.

@monkey92t
Copy link
Collaborator

I really want to upgrade to Go 1.18, but some cloud platforms only support Go 1.7, and it makes me cry.

wt? 1.7?

@Shirtiny
Copy link

I really want to upgrade to Go 1.18, but some cloud platforms only support Go 1.7, and it makes me cry.

wt? 1.7?

1.17

@monkey92t
Copy link
Collaborator

We only support the 2 latest go versions in most cases, which is also the practice of many go libraries.

kamikazechaser added a commit to grassrootseconomics/asynq that referenced this pull request Apr 8, 2023
hibiken pushed a commit to hibiken/asynq that referenced this pull request Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants