Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up connections by sending SetInfo via a pipeline #2880

Merged
merged 5 commits into from
Feb 15, 2024

Conversation

ofekshenawa
Copy link
Collaborator

No description provided.

@chayim
Copy link
Contributor

chayim commented Feb 12, 2024

part of #2850

@ofekshenawa ofekshenawa marked this pull request as ready for review February 14, 2024 22:06
@chayim chayim added the feature label Feb 15, 2024
@chayim chayim changed the title Send Client SetInfo via Pipe in Connection Init Speed up connections by sending SetInfo via a pipeline Feb 15, 2024
@chayim chayim added this to the connection-improvements milestone Feb 15, 2024
@ofekshenawa ofekshenawa merged commit 35de49a into master Feb 15, 2024
9 checks passed
@git-hulk
Copy link
Contributor

git-hulk commented Feb 18, 2024

@ofekshenawa @chayim This change will break users using Redis version < 7.2 which doesn't support the CLIENT SETINFO command. The previous version works well since the command error was ignored, bringing them into the pipeline will throw an error.

BTW, I think it'd be better to set DisableIndentity to true by default, for the sake of 7.2 is too new to most users. I will be happy to send a PR to resolve this if it sounds good to you!

@svenwltr
Copy link

Hello! This was released in a minor update release, but it would break all our apps, since we are using KeyDB and as far as I see it does not support CLIENT SETINFO.

Looking at the references to this PR, we are not the only ones having issues.

Are there plans for fixing this or workarounds available?

@SlevinWasAlreadyTaken
Copy link

Same for me, I think there is a regression or a breaking change. I run into this error while calling redis client.Ping: ERR unknown subcommand 'setinfo'. Try CLIENT HELP.

@homme
Copy link

homme commented Feb 20, 2024

Follow #2911 if you've found your way here because this change is breaking your apps.

@ofekshenawa ofekshenawa deleted the os-improve-connection-speed branch June 19, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants