Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RediSearch Dialect Version Configuration Option #3447

Closed
uglide opened this issue May 29, 2023 · 0 comments · Fixed by #3452
Closed

Add RediSearch Dialect Version Configuration Option #3447

uglide opened this issue May 29, 2023 · 0 comments · Fixed by #3452
Assignees
Milestone

Comments

@uglide
Copy link
Contributor

uglide commented May 29, 2023

In the current implementation of the client, users are required to specify the RediSearch dialect version for every FT.SEARCH or FT.AGGREGATE command. This repetitive configuration process might be prone to errors and can lead to inconsistency issues across different parts of a project where different dialect versions might be unintentionally used.

In order to make our client more user-friendly and maintain consistency throughout the usage, we need to provide a configuration option that allows users to set the RediSearch dialect version at the connection level. This will ensure the specified version is used across all FT.SEARCH and FT.AGGREGATE commands, removing the need to set it individually each time.

Acceptance Criteria:

  • A new configuration option should be added to the client that allows users to specify the RediSearch dialect version at the connection level.
  • This configuration option should be optional. If it is not specified, the client should fall back to the current behavior.
  • If the configuration option is set, all FT.SEARCH, FT.AGGREGATE, FT.EXPLAIN, FT.EXPLAINCLI, and FT.SPELLCHECK commands should use the specified RediSearch dialect version by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants