Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let's release version 1.0.0 of node_redis #803

Closed
bcoe opened this issue Aug 30, 2015 · 10 comments
Closed

let's release version 1.0.0 of node_redis #803

bcoe opened this issue Aug 30, 2015 · 10 comments

Comments

@bcoe
Copy link
Contributor

bcoe commented Aug 30, 2015

Given the recent hard work the community has put into node_redis, I think we're in a good position to push a release out the door.

How do people feel about labeling this 1.0.0 to help minimize disruption to existing node_redis users (we've moved a few bits around)?

The major client-facing features going out the door with this release are:

#658 thanks @kuwabarahiroshi, this pull gives createClient URL-parsing functionality a pretty killer feature in my opinion.

208b787 thanks @BridgeAR, fixes a regression with createClient.

#749 thanks @danielbprice, fixes a long standing bug that would have caused node_redis to crash when reconnecting in monitoring mode.

Along with these client-facing features, there has been a lot of work done on the node_redis tests:

@erinspice and @bcoe moved the test-suite over to mocha from a hand-rolled approach:

#793

this should make it much easier for future contributors to jump into the codebase.

We've also got tests running again on the newest builds of iojs 🎉

#800

Any other new features that we should pay homage to in the changelog? any objections to bumping node_redis to 1.0.0 and adhering to modern thought leadership with regards to semver moving forward?

CC: @brycebaril, @blainsmith, @mranney

@bcoe bcoe added the Ready label Aug 30, 2015
@brycebaril
Copy link
Contributor

Sounds good to me

@erinishimoticha
Copy link
Contributor

Great work, everybody!

@bcoe
Copy link
Contributor Author

bcoe commented Aug 30, 2015

How does this sound to everyone?

https://github.com/NodeRedis/node_redis/pull/804/files

If everyone is cool with it, I'll release this to a next tag on npm and test with some of my projects.

@blainsmith
Copy link
Contributor

👍 and thanks for the commit mention haha.

I am excited to be apart of this. Good work everyone! High fives all around!

@erinishimoticha
Copy link
Contributor

LGTM.

@bcoe
Copy link
Contributor Author

bcoe commented Aug 30, 2015

@erinspice @brycebaril @blainsmith give this a shot:

npm install redis@next

If it passes smoke tests, let's promote next to latest sometime early in the week.

@raydog
Copy link
Contributor

raydog commented Aug 30, 2015

1.0.0 sounds good. There was also #733, which fixed multi/exec behavior with detect_buffers enabled. (Not to get too self-promotey... :P)

@bcoe
Copy link
Contributor Author

bcoe commented Aug 30, 2015

@raydog 👍 I'll amend the changelog.

@bcoe
Copy link
Contributor Author

bcoe commented Aug 31, 2015

redis@1.0.0 is released: https://www.npmjs.com/package/redis

@bcoe bcoe closed this as completed Aug 31, 2015
@kuwabarahiroshi
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants