-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
let's release version 1.0.0 of node_redis #803
Comments
Sounds good to me |
Great work, everybody! |
How does this sound to everyone? https://github.com/NodeRedis/node_redis/pull/804/files If everyone is cool with it, I'll release this to a |
👍 and thanks for the commit mention haha. I am excited to be apart of this. Good work everyone! High fives all around! |
LGTM. |
@erinspice @brycebaril @blainsmith give this a shot:
If it passes smoke tests, let's promote |
1.0.0 sounds good. There was also #733, which fixed multi/exec behavior with detect_buffers enabled. (Not to get too self-promotey... :P) |
@raydog 👍 I'll amend the changelog. |
|
Documentation for Heroku Redis and Redis Cloud was successfully updated :-) but not yet RedisToGo |
Given the recent hard work the community has put into node_redis, I think we're in a good position to push a release out the door.
How do people feel about labeling this
1.0.0
to help minimize disruption to existing node_redis users (we've moved a few bits around)?The major client-facing features going out the door with this release are:
#658 thanks @kuwabarahiroshi, this pull gives
createClient
URL-parsing functionality a pretty killer feature in my opinion.208b787 thanks @BridgeAR, fixes a regression with
createClient
.#749 thanks @danielbprice, fixes a long standing bug that would have caused node_redis to crash when reconnecting in monitoring mode.
Along with these client-facing features, there has been a lot of work done on the node_redis tests:
@erinspice and @bcoe moved the test-suite over to mocha from a hand-rolled approach:
#793
this should make it much easier for future contributors to jump into the codebase.
We've also got tests running again on the newest builds of iojs 🎉
#800
Any other new features that we should pay homage to in the changelog? any objections to bumping node_redis to
1.0.0
and adhering to modern thought leadership with regards to semver moving forward?CC: @brycebaril, @blainsmith, @mranney
The text was updated successfully, but these errors were encountered: