Fix bug in BuildEqualityPredicate #468
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding quotes to the predicate, redis throws/returns the following error: ``` "Invalid argument(s): Closing quote must be followed by a space or nothing at all." ``` This works: `"FT.SEARCH" "idx" @name:"Test"` But this does not: `"FT.SEARCH" "idx" (@name:"Test")` So I thought it would be safer to remove the quotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding quotes to the predicate, redis throws/returns the following error:
This works ✅ :
"FT.SEARCH" "idx" @Name:"Test"But this does not 🚫:
"FT.SEARCH" "idx" (@Name:"Test")So I thought it would be safer to remove the quotes, since the query still works without them and it is already implemented in translating
string.Contains(I actually fell back to usingstring.Containsbecause of this inconvenience)Another thing to note that even though the mentioned query did not work and returned an error when running the command in redis-cli, the code did not throw an exception and just returned empty results