Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commands don't implement CommandsProtocol.connection_pool #2730

Open
Avasam opened this issue Apr 30, 2023 · 3 comments
Open

Commands don't implement CommandsProtocol.connection_pool #2730

Avasam opened this issue Apr 30, 2023 · 3 comments

Comments

@Avasam
Copy link
Contributor

Avasam commented Apr 30, 2023

Version: redis-py 4.5.4

Platform: Any

Description:

The CommandsProtocol protocol at redis/typing.py has a connection_pool member. However, all commands that subclasses the protocol seem to be missing connection_pool in their implementation. This causes issues with type-checking tools expecting the commands to respect the Protocol.

@Avasam
Copy link
Contributor Author

Avasam commented May 1, 2023

I could make a PR to fix it, but the problem is that I don't know what was the intention. Is the protocol wrong for wanting connection_pool ? Or are the commands wrong for not implementing it? Is the variable set dynamically later down the line? If so, where, and should connection_pool be potentially None instead of potentially undefined?

Copy link
Contributor

github-actions bot commented May 1, 2024

This issue is marked stale. It will be closed in 30 days if it is not updated.

@github-actions github-actions bot added the Stale label May 1, 2024
@Avasam
Copy link
Contributor Author

Avasam commented May 1, 2024

Update. I can make a PR for this. I just need an answer first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant