-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commands don't implement CommandsProtocol.connection_pool
#2730
Comments
I could make a PR to fix it, but the problem is that I don't know what was the intention. Is the protocol wrong for wanting |
This issue is marked stale. It will be closed in 30 days if it is not updated. |
Update. I can make a PR for this. I just need an answer first. |
Version: redis-py 4.5.4
Platform: Any
Description:
The
CommandsProtocol
protocol atredis/typing.py
has aconnection_pool
member. However, all commands that subclasses the protocol seem to be missingconnection_pool
in their implementation. This causes issues with type-checking tools expecting the commands to respect the Protocol.The text was updated successfully, but these errors were encountered: