-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client with RueidisOtel missing in README docs #442
Comments
Also, @rueian when can we expect new release with connection stats? |
Hi @DestroyerAlpha, Thank you for catching the error. Would you be willing to correct the README for us as well?
These four metrics were introduced since v1.0.24:
And you have to initialize your client with the rueidisotel.NewClient constructor to instrument them. |
Can't seem to find the rueidisotel.NewClient in github.com/redis/rueidis v1.0.25-go1.18. |
Oh, rueidisotel.NewClient uses the latest otel which requires go 1.20, therefore it is not available in the |
@rueian have raised the PR to fix the documentation issue. |
LGTM. Thanks! |
In README for rueidisotel, we have imported Rueidisotel but we are not using the methods from it to initialise client.
The text was updated successfully, but these errors were encountered: