Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing a Connector config with converter specific configs removes these #938

Open
philipp94831 opened this issue Nov 27, 2023 · 3 comments
Assignees
Labels
bug Something isn't working frontend

Comments

@philipp94831
Copy link

When editing a Kafka Connector config with converter specific configs, such as

"value.converter.schema.registry.url": "http://schema-registry:8081",

the config is removed fter updating it. The value converter used in this case is io.confluent.connect.avro.AvroConverter and configured as the default value converter for the Connect cluster. The converter specific config should not be removed in this case.

@cobolbaby
Copy link

Some custom configurations will be overwritten and updated, such as database.history.producer.sasl.mechanism in debezium-connector.

2023-12-01 14-58-19屏幕截图

@rikimaru0345
Copy link
Contributor

This seems to depend on the backend/exact connector that is being used.
I tried gcs, http source, and S3 connectors, and they don't remove/change any properties.
@weeco Can you look into this and make sure it isn't an issue with the backend, or even the connector?

@philipp94831 What is the exact name of the connector you used?
Are you sending the update in JSON view, or do you switch back to the form view before updating?
Also, can you check the network tab in the chrome dev tools? There should be http PUT to the connector being sent that contains the new config.

Image

@philipp94831
Copy link
Author

Hi, I am using ElasticsearchSinkConnector. "value.converter.schema.registry.url": "http://schema-registry:8081" is part of the GET connectors request but not part of the PUT when updating the connector through form view. JSON view works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
None yet
Development

No branches or pull requests

4 participants