mark/matrix: forgive empty parametrization #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gousteris
added a commit
to gousteris/redpanda
that referenced
this pull request
Mar 13, 2023
To be able to mark tests with empty list of `matrix` parametrization as `ignore` ref redpanda#8704 redpanda-data/ducktape#24
gousteris
added a commit
to gousteris/redpanda
that referenced
this pull request
Mar 13, 2023
To be able to mark tests with empty list of `matrix` parametrization as `ignore` ref redpanda#8704 redpanda-data/ducktape#24
gousteris
added a commit
to gousteris/redpanda
that referenced
this pull request
Mar 13, 2023
To be able to mark tests with empty list of `matrix` parametrization as `ignore` ref redpanda#8704 redpanda-data/ducktape#24
ivotron
requested review from
a team,
nk-87,
ayubpathan,
dotnwat and
jcsp
and removed request for
a team
jcsp
approved these changes
Mar 14, 2023
gousteris
added a commit
to gousteris/redpanda
that referenced
this pull request
Mar 14, 2023
To be able to mark tests with empty list of `matrix` parametrization as `ignore` ref redpanda#8704 redpanda-data/ducktape#24
gousteris
force-pushed
the
fix-redpanda-8704
branch
from
fa21a76 to
5b4c316
Compare
gousteris
added a commit
to gousteris/redpanda
that referenced
this pull request
Mar 14, 2023
To be able to mark tests with empty list of `matrix` parametrization as `ignore` ref redpanda#8704 redpanda-data/ducktape#24
3 tasks
gousteris
added a commit
to gousteris/redpanda
that referenced
this pull request
Mar 15, 2023
To be able to mark tests with empty list of `matrix` parametrization as `ignore` ref redpanda#8704 redpanda-data/ducktape#24
gousteris
added a commit
to gousteris/redpanda
that referenced
this pull request
Mar 15, 2023
To be able to mark tests with empty list of `matrix` parametrization as `ignore` ref redpanda#8704 redpanda-data/ducktape#24
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this is needed in the
cloud_storage_typeparametrization of one of our tests, that applies only on Azure. So, running on AWS, thecloud_storage_typeis gonna be empty, but ducktape doesn't allow an empty list of any parameter in thematrixmark. This PR marks tests with such parametrization, asignorein order for ducktape runner to not failref redpanda-data/redpanda#8704