remove gotohelm in favor of operator gotohelm #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisseto
requested review from
JakeSCahill,
RafalKorepta and
andrewstucki
as code owners
|
Sorry for the size of this PR. The bulk of it is changes to the I will call out that there are 2 changes I don't completely understand.
|
|
Note: I did try to setup genpartial/genschema/gotohelm via |
|
Ah, I missed this in the diff the first time around. |
chrisseto
force-pushed
the
chris/p/use-operator-gotohelm
branch
from
3bfb076 to
85bac7a
Compare
Prior to this commit `gotohelm` was duplicated in the `redpanda-operator` repo. This commit removes `pkg/gotohelm` and instead depends on `pkg/gotohelm` from the redpanda-operator repository. Due to the use of `replace` directives in the go.mod of `redpanda-operator/gotohelm`, it's not currently possible to `go install` it. As a temporary workaround, the `main.go` for gotohelm has been preserved in this repository. As gotohelm now requires go >= 1.23, this commit also syncs the `flake.lock` for this repository with the redpanda-operator.
chrisseto
force-pushed
the
chris/p/use-operator-gotohelm
branch
from
85bac7a to
10b49fe
Compare
RafalKorepta
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit
gotohelmwas duplicated in theredpanda-operatorrepo.This commit removes
pkg/gotohelmand instead depends onpkg/gotohelmfrom the redpanda-operator repository. Due to the use ofreplacedirectives in the go.mod ofredpanda-operator/gotohelm, it's not currently possible togo installit. As a temporary workaround, themain.gofor gotohelm has been preserved in this repository.As gotohelm now requires go >= 1.23, this commit also syncs the
flake.lockfor this repository with the redpanda-operator.