Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fix condition for semver docker tag #175

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

weeco
Copy link
Contributor

@weeco weeco commented Nov 24, 2022

It seems like GitHub actions modified the github.event payload for push events. I could not find any changelog or documentation for this, but all documentation has been updated to switch to github.event_name nowadays. Because the docker-metadata-action already defaults to push tag events for tags with type semver we don't need the enable condition at all anymore.

@weeco weeco requested a review from BenPope November 24, 2022 10:55
Copy link
Member

@BenPope BenPope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weeco weeco merged commit cdd8e59 into master Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants