Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing cache creation, if 0 do not create any, allow flag to create #135

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alejandroEsc
Copy link
Contributor

No description provided.

@RafalKorepta
Copy link
Contributor

There is problem with integration tests:

2024-05-03T14:35:58Z	ERROR	ClusterReconciler.Reconcile	setting pod node_id annotation	{"controller": "cluster", "controllerGroup": "redpanda.vectorized.io", "controllerKind": "Cluster", "Cluster": {"name":"internal-redpanda","namespace":"default"}, "namespace": "default", "name": "internal-redpanda", "reconcileID": "216e940b-28fc-4846-a26a-5c9280e17b05", "error": "cannot fetch node id for \"external-fixed-redpanda\" node-id annotation: cluster internal-redpanda: cannot convert pod name (external-fixed-redpanda) to ordinal: parsing int failed (panda): strconv.ParseInt: parsing \"panda\": invalid syntax\ncannot fetch node id for \"internal-redpanda\" node-id annotation: cluster internal-redpanda: cannot convert pod name (internal-redpanda) to ordinal: pod name (internal-redpanda) and cluster name (internal-redpanda): invalid input parameters"}
--
  | github.com/redpanda-data/redpanda-operator/src/go/k8s/internal/controller/redpanda.(*ClusterReconciler).Reconcile
  | /work/src/go/k8s/internal/controller/redpanda/cluster_controller.go:198
  | sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile
  | /root/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:119
  | sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
  | /root/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:316
  | sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
  | /root/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:266
  | sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
  | /root/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227
  | 2024-05-03T14:35:58Z	ERROR	ClusterReconciler.Reconcile	Failed to reconcile resource	{"controller": "cluster", "controllerGroup": "redpanda.vectorized.io", "controllerKind": "Cluster", "Cluster": {"name":"external-fixed-redpanda","namespace":"default"}, "namespace": "default", "name": "external-fixed-redpanda", "reconcileID": "be524327-5b19-421f-81a4-c0414baa4f7b", "resource": "StatefulSet", "error": "failed to retrieve node port service default/external-fixed-redpanda-external: Service \"external-fixed-redpanda-external\" not found"}
  | github.com/redpanda-data/redpanda-operator/src/go/k8s/internal/controller/redpanda.(*attachedResources).Ensure
  | /work/src/go/k8s/internal/controller/redpanda/cluster_controller_attached_resources.go:70
  | github.com/redpanda-data/redpanda-operator/src/go/k8s/internal/controller/redpanda.(*ClusterReconciler).Reconcile
  | /work/src/go/k8s/internal/controller/redpanda/cluster_controller.go:202
  | sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile
  | /root/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:119
  | sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
  | /root/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:316
  | sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
  | /root/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:266
  | sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
  | /root/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227

https://buildkite.com/redpanda/redpanda-operator/builds/1350#018f3ede-8c4b-40fb-9165-a531e6684f6a/691-744

@RafalKorepta
Copy link
Contributor

Maybe the log that I send is incorrect.

The ginkgo test suite timed out.

  [FAILED] Timed out after 30.001s.

Copy link
Contributor

@chrisseto chrisseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the commit message to be a bit more descriptive? An example error message and then a brief description of how this change resolves the error would go a very long way.

src/go/k8s/cmd/main.go Show resolved Hide resolved
src/go/k8s/cmd/main.go Show resolved Hide resolved
src/go/k8s/cmd/main.go Show resolved Hide resolved
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants