v1alpha2: correct boolean unmarshalling #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisseto
force-pushed
the
chris/fix-v1alpha2-repr
branch
from
bd7377c
to
df77b59
Compare
RafalKorepta
approved these changes
May 17, 2024
RafalKorepta
force-pushed
the
chris/fix-v1alpha2-repr
branch
from
df77b59
to
4654dbe
Compare
|
I only changed/moved comments that addressed golangci-lint issues. |
Previously, the specialized boolean types for `cloud_storage_enabled`, meant to ease the transition from v1alpha1 to v1alpha2, would silently fail in certain cases leading to the value of `cloud_storage_enabled` being dropped and set to `nil`. This commit teaches both implementations how to unmarshal from both strings and booleans and correctly returns an error in cases where unmarshaling failed. Users that upgraded to `v2.1.19-24.1.2` will likely need to set `cloud_storage_enabled` as the conversion webhook will have removed whatever value was previously set.
The decommission-on-delete test case has been flaking quite frequently. The team does not currently have time to investigate and fix the test. For now, we're moving it to e2e-unstable to prevent it from holding up releases and merges. Fixing the test is tracked by #142.
chrisseto
force-pushed
the
chris/fix-v1alpha2-repr
branch
from
4654dbe
to
36342d9
Compare
RafalKorepta
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the specialized boolean types for
cloud_storage_enabled, meant to ease the transition from v1alpha1 to v1alpha2, would silently fail in certain cases leading to the value ofcloud_storage_enabledbeing dropped and set tonil.This commit teaches both implementations how to unmarshal from both strings and booleans and correctly returns an error in cases where unmarshaling failed.
Users that upgraded to
v2.1.19-24.1.2will likely need to setcloud_storage_enabledas the conversion webhook will have removed whatever value was previously set.