v1alpha2: correct boolean unmarshalling #141
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the specialized boolean types for
cloud_storage_enabled
, meant to ease the transition from v1alpha1 to v1alpha2, would silently fail in certain cases leading to the value ofcloud_storage_enabled
being dropped and set tonil
.This commit teaches both implementations how to unmarshal from both strings and booleans and correctly returns an error in cases where unmarshaling failed.
Users that upgraded to
v2.1.19-24.1.2
will likely need to setcloud_storage_enabled
as the conversion webhook will have removed whatever value was previously set.