Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🫐 🐛 Disabling the external service doesn't seem to work #145

Open
c4milo opened this issue May 22, 2024 · 1 comment
Open

🫐 🐛 Disabling the external service doesn't seem to work #145

c4milo opened this issue May 22, 2024 · 1 comment

Comments

@c4milo
Copy link
Member

c4milo commented May 22, 2024

If operators wish to manage the nodeport service themselves after having a cluster running, they would have to do extra work to remove the service managed by the operator/helm safely.

What happened?

diff --git a/redpanda/redpanda_cluster/helm_charts/redpanda-cluster/templates/redpanda-cluster.yml b/redpanda/redpanda_cluster/helm_charts/redpanda-cluster/templates/redpanda-cluster.yml
index 98cb1e3..9b6b8b6 100644
--- a/redpanda/redpanda_cluster/helm_charts/redpanda-cluster/templates/redpanda-cluster.yml
+++ b/redpanda/redpanda_cluster/helm_charts/redpanda-cluster/templates/redpanda-cluster.yml
@@ -39,15 +39,17 @@ spec:
         {{- toYaml .Values.nodeConfig | nindent 8 }}
     image:
       {{- toYaml .Values.containerImage | nindent 6 }}
-    # K8s NodePort service
+    # We disable the operator provided nodeport service becuase we need
+    # more flexiblity than the operator abstraction provides, for Private Links.
     external:
-      enabled: true
+      # Only disables the NodePort service, prefixTemplate is still used and active.
+      enabled: false
       service:
-        enabled: true
+        enabled: false
       domain: {{ .Values.baseDNSName }}
       type: NodePort
       externalDns:
-        enabled: true
+        enabled: false # no-op with NodePort service
       addresses:
         - $PREFIX_TEMPLATE
       # We have to use pod ordinal first because that's what external-dns-helper is doing.
Screenshot 2024-05-22 at 2 32 58 PM

What did you expect to happen?

I was expecting the nodeport redpanda-broker-external service to be removed.

How can we reproduce it (as minimally and precisely as possible)?. Please include values file.

  1. Deploy a cluster with external service enabled
  2. Wait for it to be healthy
  3. Disable nodeport service

Anything else we need to know?

No response

Which are the affected charts?

Redpanda, Operator

Chart Version(s)

5.8.5

Cloud provider

Azure

JIRA Link: K8S-233

JIRA Link: K8S-234

@chrisseto
Copy link
Contributor

Camilo shared the helmrelease values from this cluster and we found that externalDns is being marshaled to {}. This is because enabled is a bool and not a *bool.

This is another point on the "bugs caused due to CRDs and values being out of sync". I'll make a tracking ticket and link back to this one.

For now this can be worked around by setting enabled to true or omitting the ExternalDns stanza all together.

@chrisseto chrisseto transferred this issue from redpanda-data/helm-charts May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants