Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nodepools #167

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Nodepools #167

wants to merge 7 commits into from

Conversation

koikonom
Copy link
Contributor

@koikonom koikonom commented Jul 5, 2024

Still work in progress.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@koikonom
scaling down by removing a nodepool
a353089 
also bugfixes and changes to some tests
@koikonom
backwards compatibility initial take
12b9c4a
@koikonom
Fix downscaling
eee9f9d 
Introducing GetNodePools() caused a bug because it was not taking
removed node pools under consideration.

As a result when we wanted to scale down a cluster we could not find a
mapping of the node ID during AdminAPI client creation, because the
removed nodepools were not part of the list.
@koikonom
Order list of nodepools when creating seed list
3117a9e 
We need to always return the same list of seed nodes to all nodes. Since
the status object is a map the ordering is not guaranteed.
@koikonom
use nodepool resources when calculating additional arguments
6c28e10
@koikonom
Add per node pool readyreplicas and use it when determining which np …
954f5e2 
…to use for seed list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonlord simonlord Awaiting requested review from simonlord

@sbocinec sbocinec Awaiting requested review from sbocinec

@0xdiba 0xdiba Awaiting requested review from 0xdiba

@birdayz birdayz Awaiting requested review from birdayz

@RafalKorepta RafalKorepta Awaiting requested review from RafalKorepta RafalKorepta will be requested when the pull request is marked ready for review RafalKorepta is a code owner

@chrisseto chrisseto Awaiting requested review from chrisseto chrisseto will be requested when the pull request is marked ready for review chrisseto is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@koikonom @CLAassistant