Skip to content

Commit

Permalink
Merge pull request #21434 from vbotbuildovich/backport-pr-21427-v24.1…
Browse files Browse the repository at this point in the history
….x-881

[v24.1.x] cst/ducktape: Change assertion for deleted chunks
  • Loading branch information
piyushredpanda authored Jul 18, 2024
2 parents 4ce043f + 125a63d commit 5473a8d
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions tests/rptest/tests/cloud_storage_chunk_read_path_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -229,12 +229,6 @@ def test_read_chunks(self):
self._assert_not_in_cache(
fr'.*kafka/{self.topic}/.*\.log\.[0-9]+$')

# We cannot assert that there are chunks in cache because the deleting thread
# could delete them all before we run the assertion, causing it to fail.
# We can check that the thread deleted some chunks.
assert rm_chunks.deleted_chunks > 0, "Expected to delete some chunk files during rand-cons, none deleted"
rm_chunks.deleted_chunks = 0

consumer = KgoVerifierSeqConsumer(self.test_context,
self.redpanda,
self.topic,
Expand All @@ -244,7 +238,7 @@ def test_read_chunks(self):
consumer.wait(timeout_sec=120)
rm_chunks.stop()
rm_chunks.join(timeout=10)
assert rm_chunks.deleted_chunks > 0, "Expected to delete some chunk files during seq-cons, none deleted"
assert rm_chunks.deleted_chunks > 0, "Expected to delete some chunk files, none deleted"

self._assert_not_in_cache(
fr'.*kafka/{self.topic}/.*\.log\.[0-9]+$')
Expand Down

0 comments on commit 5473a8d

Please sign in to comment.