Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timequery should have a check if remote read is enabled #12920

Closed
incident-io bot opened this issue Aug 22, 2023 · 0 comments · Fixed by #17533
Closed

Timequery should have a check if remote read is enabled #12920

incident-io bot opened this issue Aug 22, 2023 · 0 comments · Fixed by #17533
Assignees
@piyushredpanda
Labels
area/cloud-storage Shadow indexing subsystem P3 Default Priority - Sometime in the next year remediation Incident follow-ups that also show up in Incident.io when this label is used.

Comments

@incident-io
Copy link

incident-io bot commented Aug 22, 2023 •
edited by jira bot
Loading

In this code block,

redpanda/src/v/cluster/partition.cc

Lines 633 to 636 in a7f0f8b

bool partition::may_read_from_cloud() const {
return _cloud_storage_partition
&& _cloud_storage_partition->is_data_available();
}
, it should check if remote.read is enabled.

This action was created from Incident 330 by Daisuke Kobayashi (UTC plus 9; Tokyo), using incident.io 🔥

JIRA Link: CORE-1412
@incident-io incident-io bot added area/cloud-storage Shadow indexing subsystem P3 Default Priority - Sometime in the next year labels Aug 22, 2023
@piyushredpanda piyushredpanda added the remediation Incident follow-ups that also show up in Incident.io when this label is used. label Aug 22, 2023
@WillemKauf WillemKauf mentioned this issue Apr 1, 2024
Merged
6 tasks
This was referenced Apr 30, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@piyushredpanda piyushredpanda

Labels
area/cloud-storage Shadow indexing subsystem P3 Default Priority - Sometime in the next year remediation Incident follow-ups that also show up in Incident.io when this label is used.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CORE-1412: cluster: remote read check in partition timequery WillemKauf/redpanda
1 participant
@piyushredpanda