cloud_roles: Fix metrics lifetime #11155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limit the lifetime of the metrics to the async lifetime of `refresh_credentials`. Fixes redpanda-data#11095 Fixes redpanda-data#11107 Signed-off-by: Ben Pope <ben@redpanda.com>
rockwotj
approved these changes
Jun 1, 2023
No occurrences on v23.1.x in the last 14d / 55 runs. |
|
CI failures exist outside of this PR:
(still waiting for unit tests to complete - they're taking longer than usual) |
|
Okay so I tracked this down and it's due to the move constructor being invoked on the probe here This causes the I'm going to post a note to the team about probe lifetimes and then also do a pass of disabling the move constructors for probes and see what breaks. AFAIK this bug has always been there, but maybe clang's sanitizers only got good enough to recognize it after the clang16 upgrade? |
rockwotj
added a commit
to rockwotj/redpanda
that referenced
this pull request
Jun 2, 2023
Probes register metrics by capturing `this`, and it's not save to move them after that. In a lot of places this is safe because their lifetime is directly tied to a service which lives the whole program's lifetime, but any small move of that object even during initialization can break things (see redpanda-data#11155, redpanda-data#11095, redpanda-data#11107). This takes a big hammer approach to removing this foot gun by making all probes immovable and wrapping them in `std::unique_ptr`. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
7 tasks
rockwotj
added a commit
to rockwotj/redpanda
that referenced
this pull request
Jun 2, 2023
Probes register metrics by capturing `this`, and it's not save to move them after that. In a lot of places this is safe because their lifetime is directly tied to a service which lives the whole program's lifetime, but any small move of that object even during initialization can break things (see redpanda-data#11155, redpanda-data#11095, redpanda-data#11107). This takes a big hammer approach to removing this foot gun by making all probes immovable and wrapping them in `std::unique_ptr`. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
rockwotj
added a commit
to rockwotj/redpanda
that referenced
this pull request
Jun 2, 2023
Probes register metrics by capturing `this`, and it's not save to move them after that. In a lot of places this is safe because their lifetime is directly tied to a service which lives the whole program's lifetime, but any small move of that object even during initialization can break things (see redpanda-data#11155, redpanda-data#11095, redpanda-data#11107). This takes a big hammer approach to removing this foot gun by making all probes immovable and wrapping them in `std::unique_ptr`. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
Thanks @rockwotj good idea
Yeh I think that is a reasonable hypothesis. |
rockwotj
added a commit
to rockwotj/redpanda
that referenced
this pull request
Jun 2, 2023
Probes register metrics by capturing `this`, and it's not save to move them after that. In a lot of places this is safe because their lifetime is directly tied to a service which lives the whole program's lifetime, but any small move of that object even during initialization can break things (see redpanda-data#11155, redpanda-data#11095, redpanda-data#11107). This takes a big hammer approach to removing this foot gun by making all probes immovable and wrapping them in `std::unique_ptr`. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
|
Thank you, gentlemen! |
rockwotj
added a commit
to rockwotj/redpanda
that referenced
this pull request
Jun 2, 2023
Probes register metrics by capturing `this`, and it's not save to move them after that. In a lot of places this is safe because their lifetime is directly tied to a service which lives the whole program's lifetime, but any small move of that object even during initialization can break things (see redpanda-data#11155, redpanda-data#11095, redpanda-data#11107). This takes a big hammer approach to removing this foot gun by making all probes immovable and wrapping them in `std::unique_ptr`. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
rockwotj
added a commit
to rockwotj/redpanda
that referenced
this pull request
Jun 2, 2023
Probes register metrics by capturing `this`, and it's not save to move them after that. In a lot of places this is safe because their lifetime is directly tied to a service which lives the whole program's lifetime, but any small move of that object even during initialization can break things (see redpanda-data#11155, redpanda-data#11095, redpanda-data#11107). This takes a big hammer approach to removing this foot gun by making all probes immovable and wrapping them in `std::unique_ptr`. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
rockwotj
added a commit
to rockwotj/redpanda
that referenced
this pull request
Jun 3, 2023
Probes register metrics by capturing `this`, and it's not save to move them after that. In a lot of places this is safe because their lifetime is directly tied to a service which lives the whole program's lifetime, but any small move of that object even during initialization can break things (see redpanda-data#11155, redpanda-data#11095, redpanda-data#11107). This takes a big hammer approach to removing this foot gun by making all probes immovable and wrapping them in `std::unique_ptr`. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
rockwotj
added a commit
to rockwotj/redpanda
that referenced
this pull request
Jun 5, 2023
Probes register metrics by capturing `this`, and it's not save to move them after that. In a lot of places this is safe because their lifetime is directly tied to a service which lives the whole program's lifetime, but any small move of that object even during initialization can break things (see redpanda-data#11155, redpanda-data#11095, redpanda-data#11107). This takes a big hammer approach to removing this foot gun by making all probes immovable and wrapping them in `std::unique_ptr`. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
rockwotj
added a commit
to rockwotj/redpanda
that referenced
this pull request
Jun 12, 2023
Probes register metrics by capturing `this`, and it's not save to move them after that. In a lot of places this is safe because their lifetime is directly tied to a service which lives the whole program's lifetime, but any small move of that object even during initialization can break things (see redpanda-data#11155, redpanda-data#11095, redpanda-data#11107). This takes a big hammer approach to removing this foot gun by making all probes immovable and wrapping them in `std::unique_ptr`. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit the lifetime of the metrics to the async lifetime of
refresh_credentials.Fixes #11095
Fixes #11107
Backports Required
No occurrences on v23.1.x in the last 14d / 55 runs.
Release Notes