cloud_storage/ducktape: Ensure segments are compactible #12010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In stress test when asserting that some number of compacted segments have been uploaded, this change sets a fixed cardinality for keys so that the segments are always compactible. This is necessary because during compacted segment reupload we do not reupload unless the segment size has decreased. This check can end up in preventing upload of compacted segments to the cloud, until all uploaded compacted segments fall off the end of the manifest and we are left with no compacted segments in the manifest, failing the test assertions.
VladLazar
approved these changes
Jul 11, 2023
jcsp
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In stress test when asserting that some number of compacted segments have been uploaded, this change sets a fixed cardinality for keys so that the segments are always compactible.
This is necessary because during compacted segment reupload we do not reupload unless the segment size has decreased.
This check can end up in preventing upload of compacted segments to the cloud, until all uploaded compacted segments fall off the end of the manifest and we are left with no compacted segments in the manifest, failing the test assertions.
FIXES #10836
Backports Required
Release Notes