cloud_storage/ducktape: Wait for chunk observer to stop #14032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests which use chunk observer should wait for it to stop after the stop command is issued, to avoid the underlying set changing while it is being read from.
|
/ci-repeat 10 |
VladLazar
approved these changes
Oct 11, 2023
| @@ -369,6 +369,9 @@ def test_read_when_cache_smaller_than_segment_size(self): | |||
|
|
|||
| self._consume_baseline(timeout=180, max_msgs=read_count) | |||
| observe_cache_dir.stop() | |||
| observe_cache_dir.join(timeout=10) | |||
There was a problem hiding this comment.
suggestion: this works, but it's a bit annoying to use. perhaps we could expose an interface a la with ObserveCacheDir(..) as observer: ...
There was a problem hiding this comment.
Yeah, we can make it into a context manager, if we end up adding another call site for this utility I will add it (right now there is just one)
|
/backport v23.2.x |
|
/backport v23.2.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests which use chunk observer should wait for it to stop after the stop command is issued, to avoid the underlying set changing while it is being read from.
FIXES #13233
Backports Required
Release Notes