Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v23.3.x] rpk: prevent segfault by checking ready-clusters #17585

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #17553

If the cluster state is != ready, the cloud
response wont contain the kafkaAPI field, resulting
in a segfault.

Now, we will limit the profile creation to only
clusters that are "ready".

(cherry picked from commit 77f26c0)
@vbotbuildovich vbotbuildovich requested a review from twmb as a code owner April 3, 2024 15:31
@vbotbuildovich vbotbuildovich added this to the v23.3.x-next milestone Apr 3, 2024
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Apr 3, 2024
@r-vasquez r-vasquez self-assigned this Apr 3, 2024
@piyushredpanda
Copy link
Contributor

Known failures: #14892 and #17198

@piyushredpanda piyushredpanda merged commit 8b71c35 into redpanda-data:v23.3.x Apr 3, 2024
19 of 23 checks passed
@piyushredpanda piyushredpanda modified the milestones: v23.3.x-next, v23.3.11 Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rpk kind/backport PRs targeting a stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants