Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpk: add --node-ids option to rpk cluster partitions list #17945

Merged
merged 1 commit into from
Apr 26, 2024
Merged

rpk: add --node-ids option to rpk cluster partitions list #17945

merged 1 commit into from
Apr 26, 2024

Conversation

daisukebe
Copy link
Contributor

@daisukebe daisukebe commented Apr 18, 2024 •
edited
Loading

When using rpk cluster partitions list, it's useful if we could filter the list of partitions with broker IDs. I've added a new --node-ids option to the command.

List partitions which replicas are assigned to brokers 1 and 2.

  rpk cluster partitions list foo --node-ids 1,2

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

Features

  • rpk: rpk cluster partitions list now supports filtering with broker IDs.

r-vasquez
r-vasquez reviewed Apr 19, 2024
View reviewed changes
Copy link
Contributor

@r-vasquez r-vasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a few comments, the most important one is the --broker flag naming 👍

src/go/rpk/pkg/cli/cluster/partitions/list.go Outdated Show resolved Hide resolved
src/go/rpk/pkg/cli/cluster/partitions/list.go Outdated Show resolved Hide resolved
src/go/rpk/pkg/cli/cluster/partitions/list.go Outdated Show resolved Hide resolved
src/go/rpk/pkg/cli/cluster/partitions/list.go Outdated Show resolved Hide resolved
@daisukebe daisukebe force-pushed the rpk-enhance-list-partitions branch from 83b5481 to 976a7fa Compare April 23, 2024 04:43
@daisukebe daisukebe requested a review from r-vasquez April 23, 2024 04:44
@daisukebe
Copy link
Contributor Author

  • Changed the option name from --brokers to --node-ids
  • Made the help text explicit the given node-ids are inclusive
  • Removed the redundant check

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Apr 23, 2024 •
edited
Loading

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/48131#018f099f-cb28-4152-91f5-2a2270522e9a

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/48131#018f098f-bf79-48df-9107-e3b2ea130967

@daisukebe daisukebe changed the title rpk: add --brokers option to rpk cluster partitions list rpk: add --node-ids option to rpk cluster partitions list Apr 23, 2024
r-vasquez
r-vasquez approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@r-vasquez r-vasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@daisukebe daisukebe merged commit 4d7d8fc into redpanda-data:dev Apr 26, 2024
25 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

@vbotbuildovich vbotbuildovich mentioned this pull request Apr 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-vasquez r-vasquez r-vasquez approved these changes

@twmb twmb Awaiting requested review from twmb twmb is a code owner

@gene-redpanda gene-redpanda Awaiting requested review from gene-redpanda gene-redpanda is a code owner

Assignees
No one assigned
Labels
area/rpk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daisukebe @vbotbuildovich @r-vasquez