Stephan/revert polling removal #18090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as deprecated" This reverts commit c735156. There is scenarios where polling with high debounce can be used to limit fetch perf impact (at the cost of high latency).
This reverts commit dd4676a. Will be replaced with 23.3 commit
This reverts commit 44bde8d. Will be replaced with 23.3 commit
The `kafka_latency_fetch_latency` metric originally measured the time it'd take to complete one fetch poll. A fetch poll would create a fetch plan then execute it in parallel on every shard. On a given shard `fetch_ntps_in_parallel` would account for the majority of the execution time of the plan. Since fetches are no longer implemented by polling there isn't an exactly equivalent measurement that can be assigned to the metric. This commit instead records the duration of the first call to `fetch_ntps_in_parallel` on every shard to the metric. This first call takes as long as it would during a fetch poll. Hence the resulting measurement should be close to the duration of a fetch poll. (cherry picked from commit 44bde8d)
micheleRP
reviewed
Apr 26, 2024
| , fetch_read_strategy( | ||
| *this, | ||
| "fetch_read_strategy", | ||
| "The strategy used to fulfill fetch requests", |
There was a problem hiding this comment.
Suggested change
| "The strategy used to fulfill fetch requests", | |
| "The strategy used to fulfill fetch requests.", |
ballard26
approved these changes
Apr 30, 2024
|
/backport v24.1.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports Required
Release Notes
Features
fetch_read_strategycluster config property to select betweenpollingandnon-pollingfetch implementations. Uses thenon-pollingfetch implementation by default.