Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v23.3.x] admin: fix cache trim parameter order #18764

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

andrwng
Copy link
Contributor

@andrwng andrwng commented Jun 3, 2024

Backport of #18732
Fixes #18734

CONFLICTS:

  • uses [] instead of params due to lack of 45ba8c9

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

Bug Fixes

  • Fixes incorrect ordering of arguments in the cloud cache trim admin endpoint.

andrwng added 3 commits June 3, 2024 13:50
The arguments are reversed.

(cherry picked from commit 1d6f388)
We don't expect these to be frequent by any means. It's useful to know
about the input parameters, e.g. in case there's a bug in running it.

(cherry picked from commit 3fd9135)
CONFLICT:
- uses [] instead of get_param from httpd

- get_integer_query_param() returns a uint64_t
- revision ids are int64_t

(cherry picked from commit a6fcac5)
@andrwng andrwng force-pushed the backport-18732-v23.3.x-737 branch from 22463b5 to 74637f5 Compare June 3, 2024 20:51
@andrwng andrwng requested review from dotnwat, jcipar and WillemKauf June 4, 2024 16:14
@andrwng andrwng merged commit e91d6b9 into redpanda-data:v23.3.x Jun 4, 2024
17 checks passed
@BenPope BenPope added this to the v23.3.17 milestone Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants