[v23.3.x] cloud: Add config options to trigger cache trim #19624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcipar
force-pushed
the
backport-pr-18756-v23.3.x-194
branch
from
d71c3fd to
9622c8f
Compare
jcipar
force-pushed
the
backport-pr-18756-v23.3.x-194
branch
4 times, most recently
from
f71f6c5 to
4fd6f7c
Compare
dotnwat
reviewed
Jun 12, 2024
| @@ -35,6 +35,7 @@ | |||
| #include <algorithm> | |||
There was a problem hiding this comment.
[v24.1.x] cloud: Add config options to trigger cache trim
The commit message lists the wrong target version.
src/v/config/configuration.cc
Outdated
Comment on lines
2389
to
2397
| , cloud_storage_cache_num_buckets( | ||
| *this, | ||
| "cloud_storage_cache_num_buckets", | ||
| "Divide cloud storage cache across specified number of buckets. This " | ||
| "only works for objects with randomized prefixes. The names will not be " | ||
| "changed if the value is set to zero.", | ||
| {.needs_restart = needs_restart::no, .visibility = visibility::tunable}, | ||
| 0, | ||
| {.min = 0, .max = 1024}) |
There was a problem hiding this comment.
I don't see this used in the diff. Is it necessary? If so, please document. Otherwise, can we remove it?
jcipar
force-pushed
the
backport-pr-18756-v23.3.x-194
branch
from
4fd6f7c to
4b4f69f
Compare
andrwng
approved these changes
Jun 12, 2024
dotnwat
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #18756
Backports Required
Release Notes