c/p_balancer: fixed possible overflow of final used ration #19794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replicas eviction policy is asynchronously applied to each partition it may happen that the size of individual partitions is not exactly equal to the total usage size reported. In this case the individual partition sizes that are moved out of the node may sum up to a value larger than the total used bytes. Added a code preventing overflowing the final ratio in this case Signed-off-by: Michał Maślanka <michal@redpanda.com>
mmaslankaprv
force-pushed
the
fix-overflow-balancer
branch
from
f170a68 to
ba31bfb
Compare
bashtanov
approved these changes
Jun 12, 2024
|
new failures in https://buildkite.com/redpanda/redpanda/builds/50155#01900bc6-9866-44a9-a7ab-8c276ecf4b3d: |
ztlpn
approved these changes
Jun 12, 2024
|
ci failure: #14139 |
|
/backport v24.1.x |
|
/backport v23.3.x |
|
/backport v23.2.x |
|
/backport v24.1.x |
|
/backport v23.3.x |
|
/backport v23.2.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replicas eviction policy is asynchronously applied to each partition it may happen that the size of individual partitions is not exactly equal to the total usage size reported. In this case the individual partition sizes that are moved out of the node may sum up to a value larger than the total used bytes. Added a code preventing overflowing the final ratio in this case
Backports Required
Release Notes
Bug Fixes