Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CORE-4180] schema_registry/json: Initial commits for JSON Schema #19818

Merged
merged 2 commits into from
Jun 12, 2024
Merged

[CORE-4180] schema_registry/json: Initial commits for JSON Schema #19818

merged 2 commits into from
Jun 12, 2024

Conversation

BenPope
Copy link
Member

@BenPope BenPope commented Jun 12, 2024

Some cleanup from the initial PoC, but drops some commits, too.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

  • none

BenPope added 2 commits June 12, 2024 13:08
@BenPope
schema_registry: Introduce json_schema_definition
0128927 
Signed-off-by: Ben Pope <ben@redpanda.com>
@BenPope
schema_registry: Create json_schema_definitions
588e7b4 
Signed-off-by: Ben Pope <ben@redpanda.com>
@BenPope BenPope added the area/schema-registry Schema Registry service within Redpanda label Jun 12, 2024
@BenPope BenPope requested a review from a team June 12, 2024 14:47
@BenPope BenPope self-assigned this Jun 12, 2024
@BenPope BenPope requested review from oleiman and andijcr and removed request for a team June 12, 2024 14:47
@BenPope BenPope changed the title schema_registry/json: Initial commits for JSON Schema [CORE-4180] schema_registry/json: Initial commits for JSON Schema Jun 12, 2024
@vbotbuildovich
Copy link
Collaborator

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/50180#01900d29-33a6-45f3-b45e-36a91b7dcd94

oleiman
oleiman approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@oleiman oleiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Jun 12, 2024 •
edited
Loading

new failures in https://buildkite.com/redpanda/redpanda/builds/50180#01900d29-baeb-4a3b-ade5-0268455bb9fe:

"rptest.tests.e2e_shadow_indexing_test.EndToEndThrottlingTest.test_throttling.cloud_storage_type=CloudStorageType.ABS"

new failures in https://buildkite.com/redpanda/redpanda/builds/50180#01900d29-baee-499f-ad51-e7336682bd7a:

"rptest.tests.e2e_shadow_indexing_test.EndToEndThrottlingTest.test_throttling.cloud_storage_type=CloudStorageType.S3"

@BenPope
Copy link
Member Author

BenPope commented Jun 12, 2024

CI Failure is:

@michael-redpanda michael-redpanda merged commit f0a8ca8 into redpanda-data:dev Jun 12, 2024
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleiman oleiman oleiman approved these changes

@andijcr andijcr andijcr approved these changes

Assignees

@BenPope BenPope

Labels
area/redpanda area/schema-registry Schema Registry service within Redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BenPope @vbotbuildovich @andijcr @oleiman @michael-redpanda