Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v24.1.x] Mute just restarted nodes in leader_balancer #19832

Merged

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #18497
Fixes: #19831,

ztlpn added 2 commits June 12, 2024 22:59
Just restarted nodes may have their health reports incomplete because
not all partitions have started yet. Also right after restart the node
is probably busy catching up and replicating data that was produced in
its absense. Because of these two reasons just restarted nodes are bad
candidates for leadership transfers, mute them.

(cherry picked from commit 9042537)
Because in this test we wait for the set of objects in S3 to stabilize,
it is dependent on leader balancer timings and the previous commit makes
it fail. Give it more time to stabilize.

(cherry picked from commit 5084da5)
@vbotbuildovich vbotbuildovich added this to the v24.1.x-next milestone Jun 12, 2024
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Jun 12, 2024
@vbotbuildovich vbotbuildovich requested a review from ztlpn June 12, 2024 22:59
@ztlpn
Copy link
Contributor

ztlpn commented Jun 13, 2024

test failure looks related but it is a test problem that surfaces due to changed leader balancer timings, I'll fix it in dev.

@ztlpn ztlpn merged commit c71c9a5 into redpanda-data:v24.1.x Jun 13, 2024
19 checks passed
@piyushredpanda piyushredpanda modified the milestones: v24.1.x-next, v24.1.8 Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants