[v23.3.x] Respect target local retention settings when moving cloud enabled partition replicas #19835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With non strict local retention the storage manager will not trigger data eviction immediately when partition is eligible for eviction but will allow local data to use the whole available disk space. Using standard partition movement policy would force raft to deliver all local data over the network which is not necessary and might take long time. Changed the controller backend to always override the learner start offset when non strict retention is enabled and deliver over the network only data that would normally be retained if strict local retention is turned on. Signed-off-by: Michał Maślanka <michal@redpanda.com> (cherry picked from commit bf97be3)
Signed-off-by: Michał Maślanka <michal@redpanda.com> (cherry picked from commit 4d56cfe)
mmaslankaprv
force-pushed
the
vbotbuildovich/backport-19820-v23.3.x-72
branch
from
a6de600 to
32d6b97
Compare
ztlpn
approved these changes
Jun 13, 2024
|
the error is unrelated but relevant. i will chase that further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #19820