-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpk: group describe supporting regex #19839
rpk: group describe supporting regex #19839
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just 2 requests but thanks for doing this!
7024d9f
to
7f38f6f
Compare
Based on @r-vasquez 's feedback, made some changes below and rebased.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, thanks!
9e03d6a
to
071cb3f
Compare
/ci-repeat 3 |
@r-vasquez , is the build failure relevant? |
@daisukebe They were unrelated failures, not sure why the bot didn't retry (I did it manually). Merging it now, thanks |
/backport v24.1.x |
/backport v23.3.x |
Motivation explained in #17710
I lean towards supporting regex in the
describe
command astopic describe
does. Asgroup describe
already accepts more than one group in one command, I feel it is natural to support regex too.Fixes #17710
Backports Required
Release Notes
Improvements
--regex
flag