Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport pr 18756 v24.1.x 104 #19850

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

jcipar
Copy link
Contributor

@jcipar jcipar commented Jun 14, 2024

Backport of PR #18756

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

@jcipar jcipar requested a review from a team as a code owner June 14, 2024 13:44
@jcipar jcipar closed this Jun 21, 2024
@jcipar jcipar force-pushed the backport-pr-18756-v24.1.x-104 branch from 9ae62cc to 85350a9 Compare June 21, 2024 14:18
@bashtanov bashtanov reopened this Jun 21, 2024
Copy link
Contributor

@andrwng andrwng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could you please squash the merge commits? Or rebase so they no longer exist? They typically are meant to only be generated by CI upon merging

Copy link
Contributor

@andrwng andrwng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This otherwise lgtm, just not sure if/how the merge commits will affect anythign

@jcipar jcipar force-pushed the backport-pr-18756-v24.1.x-104 branch from 39414d9 to 2d97a39 Compare June 26, 2024 18:19
When the cloud storage cache is completely filled, puts to the cache
are blocked. This prevents readers from progressing. In some clusters
the trim operation can take a long time, up to hours. When this happens,
readers will time out, generating errors.

This commit adds two configuration options that control when the trim
is triggered. By setting these lower than the caches maximum size,
cloud storage can begin a trim operation before the cache is completely
filled, allowing readers to progress as the trim is going on in the
background.
- cloud_storage_cache_trim_threshold_size
- cloud_storage_cache_trim_threshold_objects

When a put occurs, if the cache is over these limits it triggers a trim
in the background.

(cherry picked from commit 027632c)
@jcipar jcipar force-pushed the backport-pr-18756-v24.1.x-104 branch from 2d97a39 to 8809fca Compare July 1, 2024 14:54
@jcipar jcipar merged commit f36e118 into redpanda-data:v24.1.x Jul 5, 2024
17 checks passed
@BenPope BenPope added this to the v24.1.10 milestone Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants