[v24.1.x] rpk: more debug bundle improvements #19885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the time we are reading a bundle we want to debug the most recent events. (cherry picked from commit 0577ebd)
We often trim the size of files if it exceeds the limit, we do that for multiple files, so, now we are: - moving this log to WARN. - including the filename to the log. (cherry picked from commit 7644cec)
We will use the advertised rpc address, if available, to name the bundle file if the user does not provide a filename. New format: <address>-<timestamp>-bundle.zip (cherry picked from commit 887ee5c)
Our python decoding tool takes the data directory as input and searches for redpanda/controller/0_0 and starts decoding the files. Before this change we were saving the folder in a different structure and the users who wanted to decode the logs needed to modify the tool or the directory structure. This is a QOL change that has no direct impact on UX since the logs can't be read unless we use our decoding tools. (cherry picked from commit 1b88856)
vbotbuildovich
requested review from
twmb,
r-vasquez and
gene-redpanda
as code owners
r-vasquez
approved these changes
Jun 19, 2024
This was referenced Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #19843
Fixes: #19881, Fixes: #19882, Fixes: #19883, Fixes: #19884,