CORE-5083 schema_registry: last subject deletes schema #20847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgellert
requested review from
aanthony-rp and
BenPope
and removed request for
a team
BenPope
reviewed
Jul 5, 2024
pgellert
force-pushed
the
sr/fix-permanent-delete-schema
branch
from
4711b4c to
d6e8d42
Compare
|
Force-push: code review feedback |
BenPope
previously approved these changes
Jul 5, 2024
pgellert
force-pushed
the
sr/fix-permanent-delete-schema
branch
from
d6e8d42 to
367a36e
Compare
|
Force-push: address more code review suggestions |
Add support to `store::subject_versions_has_any_of` for including deleted subject versions.
pgellert
force-pushed
the
sr/fix-permanent-delete-schema
branch
from
367a36e to
cd515cc
Compare
|
Force-push: fix linting error |
BenPope
previously approved these changes
Jul 5, 2024
andijcr
previously approved these changes
Jul 5, 2024
When the last subject version corresponding to a schema is deleted, Schema Registry should also remove the schema. On the topic, the schema is already considered deleted when the last subject version is deleted, and compaction takes care of removing it. However, without this change, compaction needs to happen and then a node restart needs to happen before the schema is removed from memory. This is not ideal for use cases where schemas are frequently created and deleted (eg. Serverless), so instead we can remove the schema from memory when its last subject version is deleted.
pgellert
force-pushed
the
sr/fix-permanent-delete-schema
branch
from
cd515cc to
d85de7b
Compare
|
Force-push: fix potential use after move |
andijcr
approved these changes
Jul 5, 2024
BenPope
approved these changes
Jul 5, 2024
|
/backport v24.1.x |
|
/backport v23.3.x |
This was referenced Jul 5, 2024
|
skipped ducktape retry in https://buildkite.com/redpanda/redpanda/builds/51160#019083d8-685b-4487-a46e-5170a19af9cb: skipped ducktape retry in https://buildkite.com/redpanda/redpanda/builds/51160#019083d8-685f-498f-b62b-4823f28f8439: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the last subject version corresponding to a schema is deleted, schema registry should also remove the schema.
On the topic, the schema is already considered deleted when the last subject version is deleted, and compaction takes care of removing it. However, without this change, compaction needs to happen and then a node restart needs to happen before the schema is removed from memory. This is not ideal for use cases where schemas are frequently created and deleted (eg. Serverless), so instead we can remove the schema from memory when its last subject version is deleted.
Fixes https://redpandadata.atlassian.net/browse/CORE-5083
Backports Required
Release Notes
Improvements