kafka: fix timequery when local log is empty #21312
Merged
+70
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before querying local log we bump the `timequery_config::min_offset`. This offset is inclusive. When local log is empty, the min_offset points one unit above the end of the log. In this PR, we add a check to return early when this is the case.
andrwng
approved these changes
Jul 9, 2024
Comment on lines
+648
to
+652
| # Restart the cluster to force segment roll. The newly created segment | ||
| # will have no user data which is what we want to test. | ||
| self.redpanda.restart_nodes(self.redpanda.nodes) | ||
| wait_until(lambda: len(list(rpk.describe_topic(topic.name))) > 0, | ||
| 30, |
There was a problem hiding this comment.
nit: mentioned in slack, you can also trigger leadership changes and that should also force a roll
|
/backport v24.1.x |
|
/backport v23.3.x |
This was referenced Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before querying local log we bump the
timequery_config::min_offset. This offset is inclusive. When local log is empty, the min_offset points one unit above the end of the log. In this PR, we add a check to return early when this is the case.Backports Required
Release Notes
Bug Fixes