[v24.1.x] cst/ducktape: Change assertion for deleted chunks #21434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because chunk readers keep open the handle to a chunk file even if the file itself is deleted, during the test_read_chunks it is possible that the sequential consumer is entirely served by these open file handles while all chunk files in the directory have been removed. This results in the assertion that some chunks must have been removed during sequential consumer to fail. As the count of chunks deleted is not important as an assertion and the purpose of deleting chunks randomly was to exercise failed materialization code path which should happen during the random consumer run, the assertion is changed to only test once for both seq and random consumers. Another alternative would be a more fine grained check, eg assert if some chunks are removed only if some files are written to the cache during a consumer run, but such checks do not buy extra value. (cherry picked from commit 866675e)
abhijat
approved these changes
Jul 17, 2024
|
/ci-repeat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #21427
Fixes: #21433,