[v24.1.x] [CORE-5672] crypto/bench: Only load context once per run #21471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenSSL doesn't appear to like being initialized, uninitialized, and then re-initialized by the same process over and over again. This results in some memory being left around and reused even after being freed which is what was causing the crypto bench test to segfault and fail. The solution is to only bring up the OpenSSL context service once per run and then bring it down when the Seastar engine is finishing up. Fixes: CORE-4207 Signed-off-by: Michael Boquard <michael@redpanda.com> (cherry picked from commit 61f9065) Conflicts: src/v/crypto/tests/crypto_bench.cc
BenPope
changed the title
michael-redpanda
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #21326
Fixes #21470