Fix http client segfault in metrics_reporter
#21579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/51916#0190dff1-a2c8-41ea-ba79-bf6316ab6414 |
dotnwat
previously approved these changes
Jul 23, 2024
In case of exceptions, destroying the client may not be safe because the underlying output stream may not be fully flushed.
It just calls client->stop() (which will make the client unusable and we need to call anyway before the client is destroyed), so remove it to avoid confusion.
mmaslankaprv
approved these changes
Jul 24, 2024
|
/backport v24.2.x |
|
/backport v24.1.x |
|
/backport v23.3.x |
|
Failed to create a backport PR to v23.3.x branch. I tried: |
This was referenced Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of exceptions, destroying the client may not be safe because the underlying output stream may not be fully flushed.
An alternative fix would be to ensure that
http::clientcan always be destroyed if no method calls are in progress, but that seems complicated and other usage sites seem to follow the convention of always stopping it anyway.Fixes https://github.com/redpanda-data/core-internal/issues/1323
Fixes https://github.com/redpanda-data/core-internal/issues/1325
Backports Required
Release Notes