Add rate-rejected connection metric #22803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust the existing metric text to clarify that is connections rejected for hitting the connection count cap, not the connection rate limit cap (as we are shortly introducing a metric for the latter). Ref CORE-6827.
We can reject connections because we hit two types of limits: the open connection limit or the rate limit (in the rate limit case we do try to wait a short period to see if accepting the connection after the wait would meet the rate, but if not we reject). Existing naming of variables, log lines etc was inconsistent using "declined" for the second case and generally not being clear about the two cases. Bring this into line by using "rejected" as the standard terminology and then "open limit" and "rate limit" being the two reasons. Log the addr in the same way too, including the port, in either case.
Add connections_rejected_rate_limit which counts connections rejected due to the rate limit, analogously to the existing metric which counts rejected connections due to the hitting the open connection limit. Fixes CORE-6827.
travisdowns
changed the title
|
@mmaslankaprv put you on review here as Vadim did the original changes. Based on the PR it looks like the intent was to add this metric originally (all the plumbing was there) but the metric was never registered. So this just fixes that. Backport to 24.2 since this is something we sort of need for existing clusters over the new few months as it is a blind spot currently. |
StephanDollberg
approved these changes
Aug 8, 2024
mmaslankaprv
approved these changes
Aug 9, 2024
|
/backport v24.2.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add connections_rejected_rate_limit which counts connections rejected
due to the rate limit, analogously to the existing metric which counts
rejected connections due to the hitting the open connection limit.
Some additional renaming & clarification of these two connection related limits.
Backports Required
Release Notes
Improvements