Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v23.3.x] CORE-7338 license: add metric #23468

Conversation

pgellert
Copy link
Contributor

@pgellert pgellert commented Sep 24, 2024

Backport of PR #23367

Fixes #23456

Conflicts were on the storage test bazel BUILD file and on some of the headers in feature_table.cc, feature_table_test.cc and license.cc.

@pgellert pgellert added this to the v23.3.x-next milestone Sep 24, 2024
@pgellert pgellert added the kind/backport PRs targeting a stable branch label Sep 24, 2024
@pgellert pgellert self-assigned this Sep 24, 2024
@pgellert pgellert requested review from BenPope and oleiman September 24, 2024 17:26
src/v/security/license.cc Outdated Show resolved Hide resolved
Expose the expiration as a time_point.

(cherry picked from commit 78de1c7)
These two fixture tests create multiple `feature_table`s at the same
time. This commit disables emitting metrics on these tests to prevent
double metric registration errors in the follow up commit of this PR.

(cherry picked from commit 1c8f66b)
Adds a metric to allow easier monitoring of when the enterprise license
is going to expiry.

The dependency on the `security` module existed even previously in the
bazel build but it was missing from the cmake build.

(cherry picked from commit edb5f48)
Adds an integration test for the license expiry metric.

(cherry picked from commit baece2c)
@pgellert pgellert force-pushed the vbotbuildovich/backport-23367-v23.3.x-95 branch from b26d4d9 to 9a6df45 Compare September 24, 2024 19:16
@pgellert
Copy link
Contributor Author

Force-push: fix incorrect merge conflict resolution

@pgellert pgellert marked this pull request as ready for review September 24, 2024 19:17
@pgellert pgellert requested a review from oleiman September 24, 2024 19:17
Copy link
Member

@oleiman oleiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pgellert pgellert merged commit def452f into redpanda-data:v23.3.x Sep 25, 2024
18 checks passed
@BenPope BenPope modified the milestones: v23.3.x-next, v23.3.22 Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants