-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v23.3.x] CORE-7338 license: add metric #23468
Merged
pgellert
merged 4 commits into
redpanda-data:v23.3.x
from
pgellert:vbotbuildovich/backport-23367-v23.3.x-95
Sep 25, 2024
Merged
[v23.3.x] CORE-7338 license: add metric #23468
pgellert
merged 4 commits into
redpanda-data:v23.3.x
from
pgellert:vbotbuildovich/backport-23367-v23.3.x-95
Sep 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleiman
reviewed
Sep 24, 2024
Expose the expiration as a time_point. (cherry picked from commit 78de1c7)
These two fixture tests create multiple `feature_table`s at the same time. This commit disables emitting metrics on these tests to prevent double metric registration errors in the follow up commit of this PR. (cherry picked from commit 1c8f66b)
Adds a metric to allow easier monitoring of when the enterprise license is going to expiry. The dependency on the `security` module existed even previously in the bazel build but it was missing from the cmake build. (cherry picked from commit edb5f48)
Adds an integration test for the license expiry metric. (cherry picked from commit baece2c)
pgellert
force-pushed
the
vbotbuildovich/backport-23367-v23.3.x-95
branch
from
September 24, 2024 19:16
b26d4d9
to
9a6df45
Compare
Force-push: fix incorrect merge conflict resolution |
oleiman
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #23367
Fixes #23456
Conflicts were on the storage test bazel BUILD file and on some of the headers in feature_table.cc, feature_table_test.cc and license.cc.