Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: bump ducktape to latest of 0.11.x #23477

Conversation

ivotron
Copy link
Member

@ivotron ivotron commented Sep 25, 2024

The fork that redpanda-data maintains has been updated and a new https://github.com/redpanda-data/ducktape/tree/0.11.x-redpanda branch contains the latest version of ducktape. This PR updates the reference of ducktape's version to the current tip of this branch. The version of kafkatest also is updated as part of this.

fixes https://redpandadata.atlassian.net/browse/PESDLC-2080

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.2.x
  • v24.1.x
  • v23.3.x

Release Notes

  • none

@ivotron ivotron requested a review from a team as a code owner September 25, 2024 17:05
@ivotron ivotron requested review from gousteris and removed request for a team September 25, 2024 17:05
@ivotron
Copy link
Member Author

ivotron commented Sep 25, 2024

/ci-repeat 1
skip-redpanda-build
release
tests/rptest/tests/full_disk_test.py::LocalDiskReportTimeTest.test_target_min_capacity_wanted_time_based

tests/setup.py Outdated
@@ -13,8 +13,8 @@
package_data={'': ['*.md']},
include_package_data=True,
install_requires=[
'ducktape@git+https://github.com/redpanda-data/ducktape.git@cad0aeaa32da8ad43a297e50d6cdb215770fd10c',
'prometheus-client==0.9.0', 'pyyaml==6.0', 'kafka-python==2.0.2',
'ducktape@git+https://github.com/ivotron/ducktape.git@48498ecec438002c3cdee6a734746447288023e4',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious if you tried upstream ducktape (plus our patches) or just 0.11.x?

Copy link
Member Author

@ivotron ivotron Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's 0.11.x plus our patches. We do plan to analyze moving to upstream, given that the latest versions contain a "deflake" feature that we could make use of instead of the ok-to-fail stuff, and also given we now use pt2.0 to handle flakies

@ivotron ivotron force-pushed the bump-ducktape-to-latest-of-upstream/0.11.x branch from b8f6050 to dcf9464 Compare September 25, 2024 21:22
@ivotron
Copy link
Member Author

ivotron commented Sep 25, 2024

/ci-repeat 1
skip-redpanda-build
release
tests/rptest/tests/full_disk_test.py::LocalDiskReportTimeTest.test_target_min_capacity_wanted_time_based

@ivotron ivotron force-pushed the bump-ducktape-to-latest-of-upstream/0.11.x branch 2 times, most recently from fa0b04e to 8cef8ad Compare September 25, 2024 22:26
@ivotron
Copy link
Member Author

ivotron commented Sep 25, 2024

/ci-repeat 1
skip-redpanda-build

@ivotron
Copy link
Member Author

ivotron commented Sep 25, 2024

after local ducktape tests finish, i'll launch tests on cloud VMs to check if all is good there, then I'll mark as ready for review

@ivotron
Copy link
Member Author

ivotron commented Sep 26, 2024

/ci-repeat 1
skip-redpanda-build
release
tests/rptest/tests/full_disk_test.py::LocalDiskReportTimeTest.test_target_min_capacity_wanted_time_based

@ivotron
Copy link
Member Author

ivotron commented Sep 26, 2024

/ci-repeat 1
skip-redpanda-build

@vbotbuildovich
Copy link
Collaborator

@ivotron
Copy link
Member Author

ivotron commented Sep 27, 2024

/ci-repeat 1
skip-redpanda-build

@ivotron
Copy link
Member Author

ivotron commented Sep 27, 2024

/cdt
rp_repo=nightly
rp_version=latest

@ivotron ivotron force-pushed the bump-ducktape-to-latest-of-upstream/0.11.x branch from 2e0c9d0 to d1b9333 Compare September 28, 2024 00:06
@ivotron
Copy link
Member Author

ivotron commented Sep 28, 2024

launched FIPS build on https://buildkite.com/redpanda/redpanda/builds/55367

@ivotron
Copy link
Member Author

ivotron commented Sep 29, 2024

@michael-redpanda @pgellert after bumping up the ducktape version, all DT tests on the FIPS job get executed, as opposed to just ~950 from before updating. However, there are some SSL errors, in addition to the ones we were seeing before related to compute_storage.py https://buildkite.com/redpanda/redpanda/builds/55367. Do you think it's OK to merge this PR and then open issues to fix those, or would you prefer those to be fixed first?

@ivotron
Copy link
Member Author

ivotron commented Sep 29, 2024

/cdt
rp_repo=nightly
rp_version=latest

@pgellert
Copy link
Contributor

all DT tests on the FIPS job get executed, as opposed to just ~950 from before updating.

Nice, thank you Ivo! 🎉 do you happen to know how the upgrade is helping with this?

Do you think it's OK to merge this PR and then open issues to fix those, or would you prefer those to be fixed first?

Yeah, I think that's OK, I don't think there's a reason to block this PR until they are fixed. @michael-redpanda what do you think?

@ivotron ivotron changed the title [WIP] bump ducktape to latest of 0.11.x tests: bump ducktape to latest of 0.11.x Sep 30, 2024
The fork that redpanda-data maintains has been updated and a new
https://github.com/redpanda-data/ducktape/tree/0.11.x-redpanda branch
contains the latest version of ducktape. This commit points to the
current tip of that branch.

Signed-off-by: Ivo Jimenez <ivo@redpanda.com>
Stop explicitly installing it and instead use whatever version ducktape
points to.

Signed-off-by: Ivo Jimenez <ivo@redpanda.com>
This is needed to reconcile dependencies between ducktape and kafkatest,
which before this were pointing to different versions of the `requests`
package.

Signed-off-by: Ivo Jimenez <ivo@redpanda.com>
@ivotron ivotron force-pushed the bump-ducktape-to-latest-of-upstream/0.11.x branch from d1b9333 to 7618b35 Compare September 30, 2024 19:06
@ivotron
Copy link
Member Author

ivotron commented Sep 30, 2024

all DT tests on the FIPS job get executed, as opposed to just ~950 from before updating.

Nice, thank you Ivo! 🎉 do you happen to know how the upgrade is helping with this?

I can only speculate since I didn't go all the way down to debugging the ones that were getting stuck. This could be due to improvements in handling connectivity to nodes.

@ivotron
Copy link
Member Author

ivotron commented Sep 30, 2024

For the regular (non-FIPS) CDT job https://buildkite.com/redpanda/redpanda/builds/55407, I see some SSL errors that are similar on. I've rebased dev to get a local DT to pass. After that, I'll lunch /dt repeats of those failures to see if they're flaky or if they're reliably failing. If the latter, then we should attempt to fix them before merging IMO

@ivotron ivotron marked this pull request as draft September 30, 2024 19:34
@ivotron
Copy link
Member Author

ivotron commented Sep 30, 2024

/ci-repeat 1
skip-redpanda-build
release

@ivotron ivotron force-pushed the bump-ducktape-to-latest-of-upstream/0.11.x branch 2 times, most recently from 5331c52 to 63b579b Compare September 30, 2024 19:43
Signed-off-by: Ivo Jimenez <ivo@redpanda.com>
@ivotron ivotron force-pushed the bump-ducktape-to-latest-of-upstream/0.11.x branch from 63b579b to 0323bac Compare September 30, 2024 19:58
@ivotron ivotron closed this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants