Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate leader balancer mode #23780

Merged
merged 7 commits into from
Oct 15, 2024

Conversation

ztlpn
Copy link
Contributor

@ztlpn ztlpn commented Oct 14, 2024

"Greedy" strategy is an older strategy that was left as an option in case there were issues with the newer topic-aware "random" strategy. Random strategy has been the default for several releases, so it doesn't make sense to keep the greedy strategy any more.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.2.x
  • v24.1.x
  • v23.3.x

Release Notes

Improvements

  • Deprecate leader_balancer_mode cluster config property.

ztlpn added 3 commits October 14, 2024 21:39
"Greedy" strategy is an older strategy that was left as an option in
case there were issues with the newer topic-aware "random" strategy.
Random strategy has been the default for several releases, so it doesn't
make sense to keep the greedy strategy any more.
This property was used to switch between optimization strategy.
Deprecate it now that just a single strategy is used.
@dotnwat
Copy link
Member

dotnwat commented Oct 14, 2024


src/v/cluster/tests/leader_balancer_test.cc:20:10: error: module //src/v/cluster/tests:leader_balancer_test does not depend on a module exporting 'utils/to_string.h'
--
  | 20 \| #include "utils/to_string.h"
  | \|          ^
  | 1 error generated.

@ztlpn ztlpn force-pushed the deprecate-leader-balancer-mode branch from ccfe7bc to 202bf2f Compare October 14, 2024 20:35
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Oct 14, 2024

@vbotbuildovich
Copy link
Collaborator

Retry command for Build#56491

please wait until all jobs are finished before running the slash command

/ci-repeat 1
tests/rptest/tests/cloud_storage_timing_stress_test.py::CloudStorageTimingStressTest.test_cloud_storage@{"cleanup_policy":"delete"}

Copy link
Contributor

@ballard26 ballard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmaslankaprv mmaslankaprv merged commit ef579f2 into redpanda-data:dev Oct 15, 2024
14 of 17 checks passed
@ztlpn ztlpn deleted the deprecate-leader-balancer-mode branch October 18, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants