Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v24.1.x] cleanup tiered storage temporary cache file if exceptions are thrown during download #24064

Merged
merged 6 commits into from
Nov 8, 2024
Merged

[v24.1.x] cleanup tiered storage temporary cache file if exceptions are thrown during download #24064

merged 6 commits into from
Nov 8, 2024

Conversation

nvartolomei
Copy link
Contributor

@nvartolomei nvartolomei commented Nov 7, 2024 •
edited
Loading

Backport of PR #24000
Closes #24056

@nvartolomei
cloud_storage: throw exception not a pointer
2c93e34 
Noticed while manually reviewing code.

No change in behavior expected.

(cherry picked from commit 6e1e998)
@nvartolomei
test_utils: extract make_throwing_stream as a test_util
0f7fe4a 
(cherry picked from commit be77f70)
@nvartolomei
cst/cache: Test current exception handling during put
beba63c 
(cherry picked from commit 5a93114)
@nvartolomei
cst/cache: Extract tmp_filepath variable
4d42839 
(cherry picked from commit 50fef29)
@nvartolomei
cst/cache: Refactor error handling during put
80620a2 
Prepare for tmp cleanup on failure.

(cherry picked from commit b34aab6)
@nvartolomei
cst/cache: Remove tmp file on put failure
e7cfdc3 
(cherry picked from commit e90eafb)
@nvartolomei nvartolomei added this to the v24.1.x-next milestone Nov 7, 2024
@nvartolomei nvartolomei added the kind/backport PRs targeting a stable branch label Nov 7, 2024
@nvartolomei nvartolomei marked this pull request as ready for review November 7, 2024 20:00
@vbotbuildovich
Copy link
Collaborator

the below tests from https://buildkite.com/redpanda/redpanda/builds/57801#01930838-0b8c-4c1f-acca-aee3dc8971ec have failed and will be retried

gtest_raft_rpunit

@nvartolomei nvartolomei enabled auto-merge November 7, 2024 22:10
@nvartolomei nvartolomei requested review from Lazin and andrwng November 7, 2024 22:26
@vbotbuildovich
Copy link
Collaborator

non flaky failures in https://buildkite.com/redpanda/redpanda/builds/57801#01930875-ddf6-4437-8c61-f35b74ea4cef:

"rptest.tests.test_si_cache_space_leak.ShadowIndexingCacheSpaceLeakTest.test_si_cache.message_size=10000.num_messages=100000.concurrency=2"

@vbotbuildovich
Copy link
Collaborator

Retry command for Build#57801

please wait until all jobs are finished before running the slash command

/ci-repeat 1
tests/rptest/tests/test_si_cache_space_leak.py::ShadowIndexingCacheSpaceLeakTest.test_si_cache@{"concurrency":2,"message_size":10000,"num_messages":100000}

@nvartolomei
Copy link
Contributor Author

/ci-repeat 1
skip-redpanda-build
tests/rptest/tests/test_si_cache_space_leak.py::ShadowIndexingCacheSpaceLeakTest.test_si_cache@{"concurrency":2,"message_size":10000,"num_messages":100000}

@andrwng
Copy link
Contributor

andrwng commented Nov 7, 2024 •
edited
Loading

I'm assuming neither backport had any functional changes. Lmk if that isn't the case

@nvartolomei nvartolomei merged commit 738692f into redpanda-data:v24.1.x Nov 8, 2024
18 checks passed
@BenPope BenPope modified the milestones: v24.1.x-next, v24.1.18 Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrwng andrwng andrwng approved these changes

@Lazin Lazin Awaiting requested review from Lazin

Assignees
No one assigned
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v24.1.18
Development

Successfully merging this pull request may close these issues.
4 participants
@nvartolomei @vbotbuildovich @andrwng @BenPope